fix(worker): Skip reuploaded but previously dropped annex objects #3617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3617 +/- ##
==========================================
- Coverage 43.09% 43.09% -0.01%
==========================================
Files 635 635
Lines 33604 33615 +11
Branches 1516 1516
==========================================
+ Hits 14483 14486 +3
- Misses 18982 18990 +8
Partials 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular upload API would repopulate dropped annex objects. This will skip objects unless the size has changed. Ideally we would only skip if the checksum was different but this requires moving to the git based uploader for the web app. This quick fix will prevent repopulating these objects and the web uploader is already skipping files of the same size otherwise.